Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polar #129

Closed
wants to merge 32 commits into from
Closed

polar #129

wants to merge 32 commits into from

Conversation

pehf
Copy link
Collaborator

@pehf pehf commented May 26, 2021

No description provided.

Nikhil Parthasarathy and others added 21 commits March 18, 2021 16:49
simple change really: we can now just rely on pyrtools.imshow / animshow
to handle the complex tensors as we want, so we remove the special
handling of them

other changes are to update docstrings and tests to be compliant with
new changes
light wrapper around pyrtools.pyrshow

still need to add tests
steerable pyramid notebook needs work in other places
works with recent changes to pyramid, adds explanation of displaying
complex tensors and using pyrshow
need to wrap steerable pyramid fixture so that its forward calls returns
a tensor
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #129 (b363272) into main (720b10c) will decrease coverage by 15.18%.
The diff coverage is 53.76%.

❗ Current head b363272 differs from pull request most recent head 07b2751. Consider uploading reports for the commit 07b2751 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #129       +/-   ##
===========================================
- Coverage   78.39%   63.20%   -15.19%     
===========================================
  Files          33       34        +1     
  Lines        2971     2965        -6     
  Branches      593      586        -7     
===========================================
- Hits         2329     1874      -455     
- Misses        465      954      +489     
+ Partials      177      137       -40     
Impacted Files Coverage Δ
plenoptic/tools/data.py 45.83% <ø> (-25.01%) ⬇️
plenoptic/tools/optim.py 96.29% <ø> (+9.19%) ⬆️
plenoptic/metric/perceptual_distance.py 34.69% <12.50%> (-46.67%) ⬇️
plenoptic/tools/signal.py 36.84% <16.66%> (+1.58%) ⬆️
plenoptic/simulate/models/factorized_pyramid.py 97.50% <97.50%> (ø)
plenoptic/metric/__init__.py 100.00% <100.00%> (ø)
...simulate/canonical_computations/non_linearities.py 92.15% <100.00%> (-1.97%) ⬇️
plenoptic/simulate/models/__init__.py 100.00% <100.00%> (ø)
plenoptic/metric/model_metric.py 28.57% <0.00%> (-71.43%) ⬇️
plenoptic/tools/display.py 12.89% <0.00%> (-57.04%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720b10c...07b2751. Read the comment docs.

@billbrod
Copy link
Collaborator

billbrod commented Sep 3, 2024

I am closing this PR. The Geodesic object, which this was primarily related to, is deprecated as of #288 , and has been moved to a new repo. The relevant changes from this PR have been included in that new repo.

@billbrod billbrod closed this Sep 3, 2024
@billbrod billbrod deleted the polar branch September 3, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants